-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
teonet.hpp: add interface for config #213
Open
angelskieglazki
wants to merge
6
commits into
develop
Choose a base branch
from
feature/config-interface-cpp
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshokhin
reviewed
May 18, 2021
noexept Co-authored-by: kshokhin <k_shokhin@wargaming.net>
kshokhin
reviewed
May 18, 2021
v-fedin
approved these changes
May 18, 2021
src/teonet.hpp
Outdated
@@ -207,7 +214,7 @@ class Teonet { | |||
/** | |||
* Sent teonet command to peer or l0 client depend of input rd | |||
* | |||
* @param ke Pointer to ksnetEvMgrClass | |||
* @param event_manager Pointer to ksnetEvMgrClass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
А тут нет этого параметра же, список с rd начинается
This method overload haven't event_manager parameter, whole list starts with rd
Co-authored-by: DmitryChernikov <47978345+chernikovdmitry@users.noreply.github.com>
kshokhin
approved these changes
May 18, 2021
Teonet library, applications, controls and components
automation
moved this from In Progress
to Ready for merge
May 18, 2021
chernikovdmitry
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.