feat: Introduce docs button #1743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
null |
faouziH21
commented
Aug 26, 2024
marcjansen
reviewed
Aug 26, 2024
|
|
||
| return ( | ||
| <SimpleButton | ||
| onClick={() => window.open('/gis-docs', '_blank')} |
There was a problem hiding this comment.
The URL should be configurable, I guess.
src/components/Header/index.tsx
Outdated
| > | ||
| </DocumentationButton> | ||
|
|
||
| </div> |
There was a problem hiding this comment.
Why do we need a wrapping <div>?
There was a problem hiding this comment.
other components used a wrapping <div> hence I chose to also wrap it in a div.
src/components/Header/index.tsx
Outdated
| </div> | ||
| ]; | ||
| insertPlugins('right', items); | ||
| if (ClientConfiguration.documentationButtonVisible) { |
There was a problem hiding this comment.
I'd move the check to the top of the function:
if (!ClientConfiguration.documentationButtonVisible) {
return;
}
github-actions bot
pushed a commit
that referenced
this pull request
Sep 11, 2024
## [8.9.0](v8.8.0...v8.9.0) (2024-09-11) ### Dependencies * **deps-dev:** bump @commitlint/cli from 19.3.0 to 19.4.0 ([46d98cc](46d98cc)) * **deps-dev:** bump @playwright/test from 1.45.3 to 1.46.0 ([6f3f6c9](6f3f6c9)) * **deps-dev:** bump @semantic-release/github from 10.1.3 to 10.1.5 ([b6286e0](b6286e0)) * **deps-dev:** bump @types/node from 22.0.2 to 22.3.0 ([5c20ba6](5c20ba6)) * **deps-dev:** bump typescript from 5.5.3 to 5.5.4 ([0d32143](0d32143)) * **deps:** bump i18next from 23.12.2 to 23.12.3 ([60b5ee6](60b5ee6)) * **deps:** bump i18next from 23.12.3 to 23.12.7 ([785e8e4](785e8e4)) * **deps:** bump react-i18next from 15.0.0 to 15.0.1 ([5537b2c](5537b2c)) ### Changes in configuration * disable dependabot ([3ccf9f1](3ccf9f1)) ### Features * adds a config for documentation button ([805b234](805b234)) * Introduce docs button ([#1743](#1743)) ([c292538](c292538)) * introduces dataType and valueMap to Displayfield ([411a1e7](411a1e7)) ### Bugfixes * escape github action conditions ([d5f8474](d5f8474))
|
🎉 This PR is included in version 8.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prev:
now: