Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes broken image symbol #1750

Merged
merged 3 commits into from
Oct 7, 2024
Merged

fix: fixes broken image symbol #1750

merged 3 commits into from
Oct 7, 2024

Conversation

faouziH21
Copy link
Contributor

previously while loading an application, if the logo was not already rendered there would be a broken image symbol. This PR removes it.

Copy link

github-actions bot commented Sep 19, 2024

Title Lines Statements Branches Functions
All Coverage: 30%
30.64% (1086/3544) 17.54% (329/1875) 34.38% (239/695)

❌ No tests were found related to the files changed

Copy link
Member

@dnlkoch dnlkoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, very nice @faouziH21!

resources/public/index.ejs Outdated Show resolved Hide resolved
resources/public/index.ejs Outdated Show resolved Hide resolved
@dnlkoch dnlkoch merged commit 9cad8fe into main Oct 7, 2024
1 check passed
@dnlkoch dnlkoch deleted the fix-broken-image branch October 7, 2024 08:28
Copy link

🎉 This PR is included in version 8.11.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version 9.0.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants