Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default JSONB (de-)serializers #466

Merged
merged 4 commits into from
Feb 15, 2022
Merged

Default JSONB (de-)serializers #466

merged 4 commits into from
Feb 15, 2022

Conversation

dnlkoch
Copy link
Member

@dnlkoch dnlkoch commented Feb 15, 2022

Description

This introduces model definitions for all JSONB interfaces (e.g. the ApplicationClientConfig) to provide some defaults which can be used without any project specific implementations.

Note: As there is a single candidate of each super type definition valid, the JsonSuperType annotations in existing serializers in project implementations must be updated to have the override flag set to true. Example:

@Data
@JsonDeserialize(as = ProjectApplicationClientConfig.class)
-@JsonSuperType(type = ApplicationClientConfig.class)
+@JsonSuperType(type = ApplicationClientConfig.class, override = true)
@JsonInclude(JsonInclude.Include.NON_NULL)
@ToString
@EqualsAndHashCode
public class ProjectApplicationClientConfig implements ApplicationClientConfig {

Please review @terrestris/devs.

Related issues or pull requests

--

Pull request type

  • Bugfix
  • Feature
  • Dependency updates
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)

Do you introduce a breaking change?

  • Yes
  • No

Checklist

  • I understand and agree that the changes in this PR will be licensed under the
    Apache Licence Version 2.0.
  • I have followed the guidelines for contributing.
  • The proposed change fits to the content of the code of conduct.
  • I have added or updated tests and documentation, and the test suite passes (run mvn test locally).
  • I have added a screenshot/screencast to illustrate the visual output of my update.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 362 files.

Valid Invalid Ignored Fixed
245 8 109 0
Click to see the invalid file list
  • shogun-lib/src/main/java/de/terrestris/shogun/lib/model/jsonb/application/DefaultApplicationClientConfig.java
  • shogun-lib/src/main/java/de/terrestris/shogun/lib/model/jsonb/application/DefaultApplicationLayerConfig.java
  • shogun-lib/src/main/java/de/terrestris/shogun/lib/model/jsonb/application/DefaultApplicationToolConfig.java
  • shogun-lib/src/main/java/de/terrestris/shogun/lib/model/jsonb/application/DefaultLayerTree.java
  • shogun-lib/src/main/java/de/terrestris/shogun/lib/model/jsonb/application/DefaultMapView.java
  • shogun-lib/src/main/java/de/terrestris/shogun/lib/model/jsonb/layer/DefaultLayerClientConfig.java
  • shogun-lib/src/main/java/de/terrestris/shogun/lib/model/jsonb/layer/DefaultLayerPropertyConfig.java
  • shogun-lib/src/main/java/de/terrestris/shogun/lib/model/jsonb/layer/DefaultLayerSourceConfig.java

@dnlkoch dnlkoch merged commit b48c63f into main Feb 15, 2022
@dnlkoch dnlkoch deleted the default-jsonb-serializers branch February 15, 2022 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants