Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust onKeycloakEvent listener condition #498

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

LukasLohoff
Copy link
Member

@LukasLohoff LukasLohoff commented Apr 14, 2022

Description

Removes the USER_GROUP_MEMBERSHIP_CHANGED condition. When a user changes group membership that should not require the user to be created in shogun.

Currently this results in conflicts with other event listeners.

@terrestris/devs Please review

Pull request type

  • Bugfix
  • Feature
  • Dependency updates
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)

Do you introduce a breaking change?

  • Yes
  • No

Checklist

  • I understand and agree that the changes in this PR will be licensed under the
    Apache Licence Version 2.0.
  • I have followed the guidelines for contributing.
  • The proposed change fits to the content of the code of conduct.
  • I have added or updated tests and documentation, and the test suite passes (run mvn test locally).
  • I have added a screenshot/screencast to illustrate the visual output of my update.

@LukasLohoff LukasLohoff marked this pull request as ready for review April 19, 2022 09:16
@LukasLohoff LukasLohoff merged commit 386c1ab into terrestris:main Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants