Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove local override of the git.commit.id.abbrev property #513

Merged
merged 1 commit into from
May 10, 2022

Conversation

dnlkoch
Copy link
Member

@dnlkoch dnlkoch commented May 10, 2022

Description

This reverts the local override of the git.commit.id.abbrev to fix the commit-based docker images:

image

Please note @terrestris/devs.

Related issues or pull requests

--

Pull request type

  • Bugfix
  • Feature
  • Dependency updates
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)

Do you introduce a breaking change?

  • Yes
  • No

Checklist

  • I understand and agree that the changes in this PR will be licensed under the
    Apache Licence Version 2.0.
  • I have followed the guidelines for contributing.
  • The proposed change fits to the content of the code of conduct.
  • I have added or updated tests and documentation, and the test suite passes (run mvn test locally).
  • I have added a screenshot/screencast to illustrate the visual output of my update.

@dnlkoch
Copy link
Member Author

dnlkoch commented May 10, 2022

Thanks for the reviews!

@dnlkoch dnlkoch merged commit 980baa4 into main May 10, 2022
@dnlkoch dnlkoch deleted the fix-git-abbrev branch May 10, 2022 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants