Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add applications to startpage #629

Merged
merged 5 commits into from
Jan 9, 2023
Merged

Feat: Add applications to startpage #629

merged 5 commits into from
Jan 9, 2023

Conversation

hblitza
Copy link
Contributor

@hblitza hblitza commented Jan 5, 2023

Description

This reorders elements on the startpage:

  • display all applications (public or for the specific user if logged in). use a simple web component for this
  • removes web socket card

image

Related issues or pull requests

Pull request type

  • Bugfix
  • Feature
  • Dependency updates
  • Tests
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)

Do you introduce a breaking change?

  • Yes
  • No

Checklist

  • I understand and agree that the changes in this PR will be licensed under the
    Apache Licence Version 2.0.
  • I have followed the guidelines for contributing.
  • The proposed change fits to the content of the code of conduct.
  • I have added or updated tests and documentation, and the test suite passes (run mvn test locally).
  • I have added a screenshot/screencast to illustrate the visual output of my update.

Copy link
Member

@dnlkoch dnlkoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome so far @hblitza!

shogun-boot/src/main/resources/templates/index.html Outdated Show resolved Hide resolved
shogun-boot/src/main/resources/templates/index.html Outdated Show resolved Hide resolved
shogun-boot/src/main/resources/templates/index.html Outdated Show resolved Hide resolved
shogun-boot/src/main/resources/templates/index.html Outdated Show resolved Hide resolved
shogun-boot/src/main/resources/templates/index.html Outdated Show resolved Hide resolved
shogun-boot/src/main/resources/templates/index.html Outdated Show resolved Hide resolved
Comment on lines +139 to +140
realm: 'SHOGun',
clientId: 'shogun-client'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

realm and clientId should be configurable.

shogun-boot/src/main/resources/templates/index.html Outdated Show resolved Hide resolved
shogun-boot/src/main/resources/templates/index.html Outdated Show resolved Hide resolved
@hblitza
Copy link
Contributor Author

hblitza commented Jan 9, 2023

Thanks for the helpful review @dnlkoch. Configuration will me addressed in follow-up PR.

@hblitza hblitza merged commit 0884b4e into main Jan 9, 2023
@hblitza hblitza deleted the startpage-redesign branch January 9, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants