-
Notifications
You must be signed in to change notification settings - Fork 887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix wrong type indicator(for jpn) #17
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems reasonable to me, but how widely tested has it been? ie what is the risk for regressions on other text? |
I tested this both horizontal writing and vertical writing (of course, Japanese text which contains alphanumeric characters). |
- Add a new entry for IPAmj Mincho - Add dummy entry for Japanese Italic/Oblique font
The policy (for recognition mistakes correction) was changed. So, Remove some entries for substitution.
udnp
added a commit
to udnp/GoIV_JP
that referenced
this pull request
Aug 21, 2017
udnp
added a commit
to udnp/GoIV_JP
that referenced
this pull request
Aug 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a few mistake that cause undesirable ocr result in jpn/jpn.unicharambigs.
Some substitution rule do not mandatory (even if vertical writing Japanese).
For example (bad result):
google -> g。。gーe
1985 -> ー985
So, I modified "type indicator(5th column)" .