Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for correct locale settings #1649

Merged
merged 1 commit into from
Jun 8, 2018
Merged

Conversation

stweil
Copy link
Contributor

@stweil stweil commented Jun 8, 2018

Normal C++ programs like those which are built for tesseract automatically
set the locale "C".

There can be different locale settings if the tesseract library is used
in other software.

A wrong locale can cause wrong results from sscanf which is used at
different places in the tesseract code, so make sure that we have the
right locale settings and fail if that is not the case.

Signed-off-by: Stefan Weil sw@weilnetz.de

Normal C++ programs like those which are built for tesseract automatically
set the locale "C".

There can be different locale settings if the tesseract library is used
in other software.

A wrong locale can cause wrong results from sscanf which is used at
different places in the tesseract code, so make sure that we have the
right locale settings and fail if that is not the case.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
@zdenop zdenop merged commit e7c1e07 into tesseract-ocr:master Jun 8, 2018
@stweil stweil deleted the locale branch June 8, 2018 21:24
@amitdo
Copy link
Collaborator

amitdo commented Nov 9, 2018

@stweil,
Can you add a short text about this PR to Release Notes?

@stweil
Copy link
Contributor Author

stweil commented Nov 9, 2018

Well, it's now a little bit more than a short text. I hope that's fine.

@amitdo amitdo added the locale label Mar 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants