Renamed GetGlyphConfidences() to GetChoices() and glyph_confidences t…

[noahmetzger]

…o lstm_choice_mode

Renamed the global attribute glyph_confidences to lstm_choice_mode and the method GetGlyphConfidences() to GetChoices(). All Variables and comments contained in related methods were renamed as well.

Signed-off-by: Noah Metzger noah.metzger@bib.uni-mannheim.de

[amitdo]

Get choices of what?

[egorpugin]

Yes, seems a bit strange name and very unclear.
I'm for longer, but more meaningful name.

In comment you wrote:
* Returns the lstm choices for every LSTM timestep for the current Word

Maybe rename to getLstmChoices()?

[Shreeshrii]

Maybe rename to getLstmChoices()?

+1

[zdenop]

So is there agreement to rename GetChoices to getLstmChoices?

[amitdo]

My point was that the name should include the relevant unit which is symbol.

[stweil]

@amitdo, which name would you prefer?

[amitdo]

GetSymbolChoices()

[zdenop]

Skipping lsmt?

[egorpugin]

I'm fine with that.

[amitdo]

You can also add lstm...

[bertsky]

So GetBestLSTMSymbolChoices then? (It's not about all choices, they are sorted by probability and capped.)

[stweil]

Please add your thumbs up to @bertsky's suggestion if I should implement it like that.

[zdenop]

let's close voting at within next 5 hours (thumbs up or down) and then @stweil can update #1998...

[amitdo]

A short description of this feature is needed here:
https://github.com/tesseract-ocr/tesseract/wiki/ReleaseNotes

[stweil]

@noahmetzger can do that on Monday.