Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some issues reported by LGTM #2000

Merged
merged 6 commits into from
Oct 18, 2018
Merged

Fix some issues reported by LGTM #2000

merged 6 commits into from
Oct 18, 2018

Commits on Oct 18, 2018

  1. LineHypothesis: Add copy assignment operator 

    This fixes a warning from LGTM:

    No matching copy assignment operator in class LineHypothesis.
    It is good practice to match a copy constructor
    with a copy assignment operator.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
    @stweil
    stweil committed Oct 18, 2018
    Configuration menu
    Copy the full SHA
    0bbd5c5 View commit details
    Browse the repository at this point in the history

  2. ParamsTrainingHypothesis: Add copy assignment operator 

    This fixes a warning from LGTM:

    No matching copy assignment operator in class ParamsTrainingHypothesis.
    It is good practice to match a copy constructor
    with a copy assignment operator.

Use also a simpler expression for the size of features.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
    @stweil
    stweil committed Oct 18, 2018
    Configuration menu
    Copy the full SHA
    7100a14 View commit details
    Browse the repository at this point in the history

  3. BLOB_CHOICE: Add copy assignment operator 

    This fixes a warning from LGTM:

    No matching copy assignment operator in class BLOB_CHOICE.
    It is good practice to match a copy constructor
    with a copy assignment operator.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
    @stweil
    stweil committed Oct 18, 2018
    Configuration menu
    Copy the full SHA
    a1f0c66 View commit details
    Browse the repository at this point in the history

  4. ROW: Add declaration for copy constructor 

    It does not need an implementation as it is currently not used.

This fixes a warning from LGTM:

    No matching copy constructor in class ROW.
    It is good practice to match a copy assignment operator
    with a copy constructor.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
    @stweil
    stweil committed Oct 18, 2018
    Configuration menu
    Copy the full SHA
    5585ed8 View commit details
    Browse the repository at this point in the history

  5. C_OUTLINE_FRAG: Add declaration for copy constructor 

    It does not need an implementation as it is currently not used.

This fixes a warning from LGTM:

    No matching copy constructor in class C_OUTLINE_FRAG.
    It is good practice to match a copy assignment operator
    with a copy constructor.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
    @stweil
    stweil committed Oct 18, 2018
    Configuration menu
    Copy the full SHA
    e3658bb View commit details
    Browse the repository at this point in the history

  6. BlamerBundle: Add declaration for copy assignment operator 

    It does not need an implementation as it is currently not used.

This fixes a warning from LGTM:

    No matching copy assignment operator in class BlamerBundle.
    It is good practice to match a copy constructor
    with a copy assignment operator.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
    @stweil
    stweil committed Oct 18, 2018
    Configuration menu
    Copy the full SHA
    f0c9b75 View commit details
    Browse the repository at this point in the history