-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move source files which are used for training only to src/training #2614
Conversation
Together with pull request #2613 this completes the symbol cleanup for the Tesseract library which now only contains symbols needed for the Tesseract executable and for the C API. The Tesseract library is reduced significantly in size by both pull requests:
|
They are moved from src/classify and src/lstm to src/training. This reduces the size of the Tesseract library. Signed-off-by: Stefan Weil <sw@weilnetz.de>
Updated PR to fix |
sampleiterator.cpp | ||
sampleiterator.h | ||
trainingsampleset.cpp | ||
trainingsampleset.h | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@egorpugin, please review my changes for CMake. I don't know why there are three libraries for training and added the moved code to one of them:
src/training/libunicharset_training.a
src/training/libtessopt.a
src/training/libcommon_training.a
Wouldn't it be simpler to have a single library for training?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it be simpler to have a single library for training?
Only in case when files are used in >1 target.
Otherwise personally I prefer to keep files near users (when use count ==1).
D:/dev/tesseract/src/classify/trainingsample.cpp(27): fatal error C1083: Cannot open include file: 'intfeaturemap.h': No such file or directory Main source file depends on training. Is it ok? |
@egorpugin, yes, some files in |
Yes, please. Now it is very dummy implementation copied from cmake and not makefiles (which seems is in better shape). |
I've removed moved files from the installation, but that single error is still there. |
They are moved from src/classify and src/lstm to src/training.
This reduces the size of the Tesseract library.
Signed-off-by: Stefan Weil sw@weilnetz.de