Extend function BoxFileName to handle more common image names #2686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egorpugin
reviewed
Oct 2, 2019
src/ccstruct/boxread.cpp
Outdated
| if (last == ".bin.png" || last == ".nrm.png") { | ||
| box_filename.resize(length - 8); | ||
| } else { | ||
| const char* lastdot = strrchr(box_filename.c_str(), '.'); |
There was a problem hiding this comment.
Good idea. str.find_last_of('.') might even be better. I'll update the PR tomorrow.
There was a problem hiding this comment.
Not sure about find_last_of().
The function derives the file name for the .box file from an image name. For training from existing line images, it is useful to directly support the image names which are commonly used. While generated images for Tesseract training typically use the name pattern NAME.tif, other ground truth sets use NAME.bin.png for binarized or NAME.nrm.png for grayscale images. BoxFileName is also now a local function as it is only used locally. Signed-off-by: Stefan Weil <sw@weilnetz.de>
|
I updated and rebased the pull request and think that it is ready for merging now. |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function derives the file name for the .box file from an image name.
For training from existing line images, it is useful to directly support
the image names which are commonly used.
While generated images for Tesseract training typically use the name
pattern NAME.tif, other ground truth sets use NAME.bin.png for binarized
or NAME.nrm.png for grayscale images.
BoxFileName is also now a local function as it is only used locally.
Signed-off-by: Stefan Weil sw@weilnetz.de