fix issue #3940 - remove colormap before thresholding #3942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egorpugin
approved these changes
Oct 14, 2022
|
Unfortunately, this patch causes even worst regression. Many of the CI jobs fails. |
|
commit 14e2517 fixed the issue detected by ASan. There are still a memory leak issue and failed tests. |
|
The failed unit tests are hopefully fixed now. |
|
Note that restarting the GitHub action uses the same old code as in the previous run and will fail again, so restarting only helps for temporary failures (network timeouts, ...). So we have to wait for the next regular action trigger. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe code for colormap removal could be simplified to
original = pixConvertTo8(original.copy(), false);but I decided to stick to original code (in SetImage).This change works for me for images in issues #3940 and #3092 and for thresholding_method 0,1,2.