Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Redpanda module #796

Merged
merged 13 commits into from
Feb 23, 2023
Merged

feat: Add Redpanda module #796

merged 13 commits into from
Feb 23, 2023

Conversation

eddumelendez
Copy link
Member

Redpanda provides a Kafka compatible API.

Redpanda provides a Kafka compatible API.
@netlify
Copy link

netlify bot commented Feb 21, 2023

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit e915263
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/63f63a24f8caf800078ae8b3
😎 Deploy Preview https://deploy-preview-796--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good! I added small suggestions to clean up some parts. I suggest to change the Init() configuration a bit. Other than that great first PR 👍 . Thanks

src/Testcontainers.Redpanda/RedpandaBuilder.cs Outdated Show resolved Hide resolved
src/Testcontainers.Redpanda/RedpandaBuilder.cs Outdated Show resolved Hide resolved
src/Testcontainers.Redpanda/RedpandaConfiguration.cs Outdated Show resolved Hide resolved
src/Testcontainers.Redpanda/RedpandaConfiguration.cs Outdated Show resolved Hide resolved
src/Testcontainers.Redpanda/RedpandaConfiguration.cs Outdated Show resolved Hide resolved
src/Testcontainers.Redpanda/RedpandaContainer.cs Outdated Show resolved Hide resolved
src/Testcontainers.Redpanda/RedpandaContainer.cs Outdated Show resolved Hide resolved
src/Testcontainers.Redpanda/Usings.cs Outdated Show resolved Hide resolved
tests/Testcontainers.Redpanda.Tests/Usings.cs Show resolved Hide resolved
HofmeisterAn and others added 12 commits February 22, 2023 09:04
Co-authored-by: Andre Hofmeister <9199345+HofmeisterAn@users.noreply.github.com>
Co-authored-by: Andre Hofmeister <9199345+HofmeisterAn@users.noreply.github.com>
Co-authored-by: Andre Hofmeister <9199345+HofmeisterAn@users.noreply.github.com>
Co-authored-by: Andre Hofmeister <9199345+HofmeisterAn@users.noreply.github.com>
Co-authored-by: Andre Hofmeister <9199345+HofmeisterAn@users.noreply.github.com>
Co-authored-by: Andre Hofmeister <9199345+HofmeisterAn@users.noreply.github.com>
Co-authored-by: Andre Hofmeister <9199345+HofmeisterAn@users.noreply.github.com>
Co-authored-by: Andre Hofmeister <9199345+HofmeisterAn@users.noreply.github.com>
Co-authored-by: Andre Hofmeister <9199345+HofmeisterAn@users.noreply.github.com>
Co-authored-by: Andre Hofmeister <9199345+HofmeisterAn@users.noreply.github.com>
Co-authored-by: Andre Hofmeister <9199345+HofmeisterAn@users.noreply.github.com>
@HofmeisterAn HofmeisterAn changed the title Add Redpanda module feat: Add Redpanda module Feb 23, 2023
@HofmeisterAn HofmeisterAn added the enhancement New feature or request label Feb 23, 2023
@HofmeisterAn HofmeisterAn merged commit a301682 into develop Feb 23, 2023
@HofmeisterAn HofmeisterAn deleted the redpanda branch February 23, 2023 10:21
HofmeisterAn added a commit that referenced this pull request Feb 27, 2023
Co-authored-by: Andre Hofmeister <9199345+HofmeisterAn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants