Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Copy files to container without removing first character from filename #938

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

HofmeisterAn
Copy link
Collaborator

What does this PR do?

The pull request removes the directory separator from the test host source directory path.

Why is it important?

The trailing directory path separator is optional. .NET does not normalize paths. If the test host source directory path ends with a separator (/, \) the first character from the filename was accidentally removed.

Related issues

-

@HofmeisterAn HofmeisterAn added the bug Something isn't working label Jun 29, 2023
@netlify
Copy link

netlify bot commented Jun 29, 2023

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit e691cd2
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/649d3511f0d6f20008a4eb76
😎 Deploy Preview https://deploy-preview-938--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@HofmeisterAn HofmeisterAn merged commit a45b6de into develop Jun 29, 2023
12 checks passed
@HofmeisterAn HofmeisterAn deleted the bugfix/do-not-remove-first-character branch June 29, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant