Fixes docker auth passwords that contain a colon (#839)

testcontainers · Oct 3, 2024 · 50df1d4 · 50df1d4
1 parent 3a1ab3a
commit 50df1d4
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/packages/testcontainers/src/container-runtime/auth/auths.test.ts b/packages/testcontainers/src/container-runtime/auth/auths.test.ts
@@ -64,5 +64,23 @@ describe("Auths", () => {
       };
       expect(await locator.getAuthConfig("https://registry.example.com", containerRuntimeConfig)).toEqual(authConfig);
     });
+
+    it("should return credentials from encoded auth when the password contains a colon", async () => {
+      const containerRuntimeConfig: ContainerRuntimeConfig = {
+        auths: {
+          "https://registry.example.com": {
+            email: "user@example.com",
+            auth: "dXNlcjpwYXNzOjE=",
+          },
+        },
+      };
+      const authConfig: AuthConfig = {
+        username: "user",
+        password: "pass:1",
+        email: "user@example.com",
+        registryAddress: "https://registry.example.com",
+      };
+      expect(await locator.getAuthConfig("https://registry.example.com", containerRuntimeConfig)).toEqual(authConfig);
+    });
   });
 });
diff --git a/packages/testcontainers/src/container-runtime/auth/auths.ts b/packages/testcontainers/src/container-runtime/auth/auths.ts
@@ -21,7 +21,9 @@ export class Auths implements RegistryAuthLocator {
 
     if (auth.auth) {
       const decodedAuth = Buffer.from(auth.auth, "base64").toString();
-      const [username, password] = decodedAuth.split(":");
+      const [username, ...passwordParts] = decodedAuth.split(":");
+      const password = passwordParts.join(":");
+
       authConfig.username = username;
       authConfig.password = password;
     } else {