-
Notifications
You must be signed in to change notification settings - Fork 143
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat!: add container startup timeout with default of 1 minute (#643)
Closes #247 - Sets default startup timeout to 1 minute - Allows to override with `RunnableImage::with_startup_timeout` Note: breaking change because of default timeout For now, ENV variable to configure global timeout isn't introduced. First of all, that's quote similar to other languages, (e.g [Go](https://golang.testcontainers.org/features/wait/introduction/#startup-timeout-and-poll-interval), [Java](https://java.testcontainers.org/features/startup_and_waits/)) Another question is which one should take precedence: ENV over `with_startup_timeout` or vice versa? We can extend it later in compatible way, so not that important at the moment.
- Loading branch information
Showing
3 changed files
with
179 additions
and
152 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.