fix(no-wait-for-side-effects): catch implicit arrow function return

[zaicevas]

Closes #351

[gndelia]

Thanks for your first PR ❤️

[Belco90]

Hey, @zaicevas thanks for your first PR! It looks great, just a couple of small tweaks, and should be ready to go.

May I ask how did you feel working within the codebase? We have put a lot of effort into making it more maintainable not only for usual contributors but also for outside ones, so any feedback you have around this would be really appreciated.

[Belco90]

Awesome! Nice work @zaicevas 🚀

Changes requested were addressed already.

[Belco90]

@all-contributors please add @zaicevas for bug, code and test

[allcontributors]

@Belco90

I've put up a pull request to add @zaicevas! 🎉

[github-actions]

🎉 This PR is included in version 4.1.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[zaicevas]

Hey, @zaicevas thanks for your first PR! It looks great, just a couple of small tweaks, and should be ready to go.

May I ask how did you feel working within the codebase? We have put a lot of effort into making it more maintainable not only for usual contributors but also for outside ones, so any feedback you have around this would be really appreciated.

The development experience is great. I enjoyed it and it's motivating to contribute more. Tests are fast, CI/CD is convenient, so it looks like it's easy to quickly make an impact. I've never coded anything eslint related, yet it didn't take me more than a couple of hours to throw this together.

For the first 30 minutes I had no idea where to start, until I've realized it's all based on AST and found https://astexplorer.net/
After that it all started to make sense and the code proved to be very clear & extendable. Perhaps it could be useful mentioning this or other similar tools in https://github.com/testing-library/eslint-plugin-testing-library/blob/main/CONTRIBUTING.md

Another that I think could be of use in CONTRIBUTING.md is a section on how to try out changes locally (besides tests). I suppose symlinking with yarn link or npm link is relatively simple and could work here.

Thanks for your first PR ❤️
Awesome! Nice work @zaicevas 🚀

More than happy to help ☺️

[Belco90]

@zaicevas thanks for your feedback, really useful! It's definitely a good idea to include some AST info and AST Explorer link to our CONTRIBUTING: the explorer is a must when dealing with AST, isn't it?

Also interesting to add a section for trying changes locally (actually someone asked the very same thing the other day in Testing Library Discord).

I'll create an issue for this.

[zaicevas]

(actually someone asked the very same thing the other day in Testing Library Discord).

That was me, by the way