chore: pin dependencies with lockfile #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Belco90
added
the
chore
Belco90
commented
Feb 2, 2023
MichaelDeBoey
requested changes
Feb 2, 2023
Co-authored-by: Michaël De Boey <info@michaeldeboey.be> Signed-off-by: Mario Beltrán <belco90@gmail.com>
|
@MichaelDeBoey Because Renovatebot is way smarter than Dependabot, has more granular control, and provides lockfile maintenance. |
|
@Belco90 Dependabot will update lock files as well |
|
@MichaelDeBoey Didn't mean just updating a dependency in the lockfile, but updating the lockfile regularly so transitive dependencies are deduped and up to date. |
|
@Belco90 Dependabot does that as well |
MichaelDeBoey
approved these changes
Feb 3, 2023
That's great! I'll check if Dependabot can do what we need then. |
|
🎉 This PR is included in version 5.10.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 6.0.0-alpha.15 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks
Changes
package-lock.jsonContext
I'm tired of getting unexpected errors in CI because our dev dependencies aren't fixed by a lock file. I'm fixing them with the npm lock file.
In a follow-up PR, I'll set up Renovatebot to keep our dev dependencies up to date automatically for us (disabling dependabot too).