Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new rule prefer-presence-queries #98

Merged
merged 10 commits into from
Mar 28, 2020
Merged

feat: new rule prefer-presence-queries #98

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
333b106
refactor: repurpose obsolete rule
Belco90 Mar 22, 2020
4f8d4c7
docs(prefer-presence-queries): update doc accordingly
Belco90 Mar 22, 2020
505abf6
feat(prefer-presence-queries): report presence or absence queries
Belco90 Mar 22, 2020
06db7c1
test(prefer-presence-queries): add more valid cases
Belco90 Mar 22, 2020
5778f2f
test(prefer-presence-queries): include correct findBy example
Belco90 Mar 23, 2020
5309be4
docs(prefer-presence-queries): fix typos
Belco90 Mar 23, 2020
7605f2e
test(prefer-presence-queries): findBy typo
Belco90 Mar 23, 2020
29f556f
feat(prefer-presence-queries): include array queries
Belco90 Mar 23, 2020
7aeab95
fix(prefer-presence-queries): guard against nil matcher
Belco90 Mar 23, 2020
dbd630b
docs(prefer-presence-queries): update appearance references
Belco90 Mar 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test(prefer-presence-queries): findBy typo
  • Loading branch information
@Belco90
Belco90 committed Mar 28, 2020
commit 7605f2e3ae74e2cd0fc05a29c3df4939386b20e1
2 changes: 1 addition & 1 deletion docs/rules/prefer-presence-queries.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ test('some test', async () => {
expect(screen.queryByText('loading')).toBeFalsy();

// `findBy*` queries are out of the scope for this rule
const button = await screen.getByText('submit');
const button = await screen.findByText('submit');
expect(button).toBeInTheDocument();
});
```
Expand Down