chore: update all packages and get 100% coverage #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This updates all the packages and gets us to 100% code coverage
Why:
Just routine maintenance as I prepare this for #115
How:
yarn upgrade-interactive --latestand manually fixing a few thingsNote that before there was one jest config, and then the tests were run with
--env jsdomfor running the same tests in both DOM and Node environments. Now we're using projects so we can run all the tests in a single test run.However this means trouble if you want to scope watch mode down to either node or DOM. So I added
jest-watch-select-projectswhich allows you to hit thePkey during watch mode and toggle on/off each of the projects so you can keep things scoped to the area where you're working.Checklist: