Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr/escape css strings #77

Merged
merged 2 commits into from
Feb 6, 2019
Merged

Pr/escape css strings #77

merged 2 commits into from
Feb 6, 2019

Conversation

mufasa71
Copy link
Contributor

@mufasa71 mufasa71 commented Feb 6, 2019

What:

Special characters should be escaped in querySelectorAll

Why:

Tests are failing due to unescaped sequence in name attribute

How:

css.escape library was added

Checklist:

  • Documentation
  • Tests
  • Updated Type Definitions
  • Ready to be merged
  • Added myself to contributors table

@gnapse gnapse merged commit dd310ee into testing-library:master Feb 6, 2019
@gnapse
Copy link
Member

gnapse commented Feb 6, 2019

Thanks!

@gnapse
Copy link
Member

gnapse commented Feb 6, 2019

🎉 This PR is included in version 3.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gnapse gnapse added the released label Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants