Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create new jobs for React next #728

Merged
merged 1 commit into from
Jul 2, 2020

Conversation

nickserv
Copy link
Member

@nickserv nickserv commented Jul 1, 2020

What:

  • Tests with both React stable and next for all builds (push and cron)
  • Allow next releases to fail the build so we can still release
  • Solves cron issues like Fix build for React next #726 that are only caused by next releases

Why: #726 and greater visibility of what's failing in React next (before a cron build is started on schedule)

How: Split React next into a new section of the build matrix rather than just using it in cron builds

Checklist:

  • Documentation added to the
    docs site N/A
  • Tests
  • Typescript definitions updated N/A
  • Ready to be merged

- Tests with both React stable and next for all builds (push and cron)
- Allow next releases to fail the build so we can still release
- Solves cron issues like #726 that are only caused by next releases
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

@codecov
Copy link

codecov bot commented Jul 1, 2020

Codecov Report

Merging #728 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #728   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          100       100           
  Branches        16        16           
=========================================
  Hits           100       100           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 386c64e...a7297b3. Read the comment docs.

@nickserv
Copy link
Member Author

nickserv commented Jul 1, 2020

https://travis-ci.org/github/testing-library/react-testing-library/builds/704028047

Seems to be working, do we want to merge this and wait for the next cron build on master?

@eps1lon eps1lon changed the title chore: create new jobs for React next (fixes #726) chore: create new jobs for React next Jul 1, 2020
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't really fix #726. The build still fails for react@next. We're just ignoring it because it's not as sever if it fails for experimental builds. We should still investigate if the issue is on our side or React's.

@nickserv
Copy link
Member Author

nickserv commented Jul 1, 2020

I see what you mean. This technically does fix the overall build though, which is what the issue was originally for. Do you want to rename it or open another issue for the timing of React next?

@eps1lon
Copy link
Member

eps1lon commented Jul 2, 2020

This technically does fix the overall build though

As far as I can tell the test is still failing. Travis even marks the build as failed. This PR makes a failing build using react@next pass github checks.

@nickserv

This comment has been minimized.

@kentcdodds kentcdodds merged commit 3c9d7b4 into master Jul 2, 2020
@kentcdodds kentcdodds deleted the pr/create-new-jobs-for-react-next branch July 2, 2020 23:28
@nickserv
Copy link
Member Author

nickserv commented Jul 3, 2020

We merged this and kept #726 open to track the specific bug with React next.

@kentcdodds
Copy link
Member

🎉 This PR is included in version 10.4.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants