Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bump @testing-library/dom to 7.22.3 #766

Merged
merged 1 commit into from
Aug 21, 2020

Conversation

radar
Copy link
Contributor

@radar radar commented Aug 20, 2020

What:

Bumping @testing-library/dom to 7.22.3.

Why:

When running tests in my project, I am seeing this console.error happen:

  console.error
    Error: Not implemented: window.computedStyle(elt, pseudoElt)
        at module.exports (/Users/ryan/code/covidence/covidence/node_modules/jsdom/lib/jsdom/browser/not-implemented.js:9:17)
        at Window.getComputedStyle (/Users/ryan/code/covidence/covidence/node_modules/jsdom/lib/jsdom/browser/Window.js:657:7)
        at computeMiscTextAlternative (/Users/ryan/code/covidence/covidence/node_modules/dom-accessibility-api/sources/accessible-name.ts:347:24)
        at computeTextAlternative (/Users/ryan/code/covidence/covidence/node_modules/dom-accessibility-api/sources/accessible-name.ts:576:11)
        at computeAccessibleName (/Users/ryan/code/covidence/covidence/node_modules/dom-accessibility-api/sources/accessible-name.ts:607:3)
        at /Users/ryan/code/covidence/covidence/node_modules/@testing-library/dom/dist/queries/role.js:96:82
        at Array.filter (<anonymous>)
        at queryAllByRole (/Users/ryan/code/covidence/covidence/node_modules/@testing-library/dom/dist/queries/role.js:90:6)
        at /Users/ryan/code/covidence/covidence/node_modules/@testing-library/dom/dist/query-helpers.js:82:17
        at /Users/ryan/code/covidence/covidence/node_modules/@testing-library/dom/dist/query-helpers.js:62:17 undefined

I suspect it is because the version of @testing-library/dom that is specified by @testing-library/react is old.

Checklist:

  • Documentation added to the
    docs site N/A
  • Tests N/A
  • Typescript definitions updated
  • Ready to be merged

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b8e2f62:

Sandbox Source
React Configuration
kentcdodds/react-testing-library-examples Configuration

@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #766 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #766   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          109       109           
  Branches        16        16           
=========================================
  Hits           109       109           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9aac157...b8e2f62. Read the comment docs.

Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let's get this fix propagated downstream.

@eps1lon eps1lon changed the title Bump @testing-library/dom to 7.22.3 fix: Bump @testing-library/dom to 7.22.3 Aug 21, 2020
@eps1lon eps1lon merged commit 276eb65 into testing-library:master Aug 21, 2020
@eps1lon
Copy link
Member

eps1lon commented Aug 21, 2020

@all-contributors add @radar for maintenance

@allcontributors
Copy link
Contributor

@eps1lon

I've put up a pull request to add @radar! 🎉

@kentcdodds
Copy link
Member

🎉 This PR is included in version 10.4.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ryota-murakami
Copy link
Contributor

Nice so quick working! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants