Shared Threadpool for normal/datadriven tests.

[krmahadevan]

Closes #2019

Fixes #2019 .

Did you remember to?

• Add test case(s)
• Update CHANGES.txt
• Auto applied styling via ./gradlew autostyleApply

We encourage pull requests that:

• Add new features to TestNG (or)
• Fix bugs in TestNG

If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.

Note: For more information on contribution guidelines please make sure you refer our Contributing section for detailed set of steps.

[juherr]

Except the dtd modification, the rest looks great.

I propose you moving and tracking all the dtd changes and related code in a dedicated pull request that we will merge once in a new dtd version (maybe even better to move to xsd). Wdyt?

[krmahadevan]

Sure. I remember the list of additions to the DTD that I made.

Now regarding the xsd, since i dont know a lot about it i had some questions

1. Would that be embedded in the jar or again hosted online?
2. If it would be hosted online how do we version control that as well without needing the users to update their suite files?

Now regarding this PR can we merge it? I was thinking of going for a release with this changeset.

[juherr]

Please exclude the dtd modification from this PR and move it to the dedicated one.

XSD is another subject we can tackle later.

[krmahadevan]

@juherr

Please exclude the dtd modification from this PR and move it to the dedicated one.

• U want the DTD modification to be done on the same file but in a separate PR (or)
• U want the DTD modification to be created in a totally different dtd file ( For e.g., this file ) ?

[juherr]

I want to merge this pr without xml potential regression or issue.

And I want to manage schema evolutions once in its own pr. With this strategy it will help to merge your previous pr too.

[krmahadevan]

I want to merge this pr without xml potential regression or issue.

And I want to manage schema evolutions once in its own pr. With this strategy it will help to merge your previous pr too.

I dont think there's going to be any regression because the DTD got updated. I havent heard of anyone relying on the DTD for some sort of code generation etc., in all these years.

Can we merge this PR as is and I will raise a new PR wherein I will remove the DTD additions from 1.0 dtd and add them to the 1.1 dtd (If this DTD getting updated is such a big concern).

[krmahadevan]

and oh btw, since u had approved the earlier PR, its already merged into master

[krmahadevan]

@juherr - Please review this PR again. I have reverted the changes done to 1.0-dtd file and added those changes to 1.1-dtd (I did this by copying the contents of 1.0-dtd to 1.1-dtd and then moving the new changes into it).