Skip to content

Commit

Permalink
refactor: Rename TPStreamPlayer playback listener method
Browse files Browse the repository at this point in the history
Renamed listener for AVPlayer.timeControlStatus from handlePlayerStatus to handlePlaybackStatus to better reflect its behavior as it monitors playback states such as playing, paused indefinitely, or waiting for network conditions to improve. This change anticipates the addition of a listener for player.status, ensuring clarity and preventing potential conflicts.
  • Loading branch information
harinath01 committed Jun 19, 2024
1 parent a9f0cb6 commit a829171
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions Source/Managers/TPStreamPlayer.swift
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class TPStreamPlayer: NSObject {
init(player: TPAVPlayer){
self.player = player
super.init()
self.observePlayerStatusChange()
self.observePlaybackStatusChange()
self.observePlayerCurrentTimeChange()
self.observeCurrentItemChanges()
}
Expand All @@ -54,7 +54,7 @@ class TPStreamPlayer: NSObject {
}
}

private func observePlayerStatusChange(){
private func observePlaybackStatusChange(){
player.addObserver(self, forKeyPath: #keyPath(TPAVPlayer.timeControlStatus), options: .new, context: nil)
}

Expand Down Expand Up @@ -87,7 +87,7 @@ class TPStreamPlayer: NSObject {
switch keyPath {
case #keyPath(TPAVPlayer.timeControlStatus):
if let player = object as? TPAVPlayer {
handlePlayerStatusChange(for: player)
handlePlaybackStatusChange(for: player)
}
case #keyPath(AVPlayerItem.isPlaybackLikelyToKeepUp), #keyPath(AVPlayerItem.isPlaybackBufferEmpty):
if let playerItem = object as? AVPlayerItem {
Expand All @@ -104,7 +104,7 @@ class TPStreamPlayer: NSObject {
status = "ended"
}

private func handlePlayerStatusChange(for player: TPAVPlayer) {
private func handlePlaybackStatusChange(for player: TPAVPlayer) {
switch player.timeControlStatus {
case .playing:
status = "playing"
Expand Down

0 comments on commit a829171

Please sign in to comment.