Skip to content

Commit

Permalink
exasol version 8 comnpatibility
Browse files Browse the repository at this point in the history
  • Loading branch information
tglunde committed Nov 22, 2023
1 parent cdf1126 commit dd88e45
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 5 deletions.
5 changes: 4 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,17 @@ OpenID login through access_token or refresh_token instead of user+password
<li><strong>socket_timeout</strong>: defaults to pyexasol default</li>
<li><strong>query_timeout</strong>: defaults to pyexasol default</li>
<li><strong>compression</strong>: default: False</li>
<li><strong>encryption</strong>: default: False</li>
<li><strong>encryption</strong>: default: True</li>
<li><strong>protocol_version</strong>: default: v3</li>
<li><strong>row_separator</strong>: default: CRLF for windows - LF otherwise</li>
<li><strong>timestamp_format</strong>: default: YYYY-MM-DDTHH:MI:SS.FF6</li>
</ul>
# Known isues
## Using encryption in Exasol 7 vs. 8
Starting from Exasol 8 encryption is enforced by default. If you are still using Exasol 7 and have trouble connecting, you can disable encryption in profiles.yml (see optional parameters).
## >=1.3 Python model not yet supported - WIP
- Please follow [this pull request](https://github.com/tglunde/dbt-exasol/pull/59)
Expand Down
2 changes: 1 addition & 1 deletion dbt/adapters/exasol/__version__.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
version = "1.4.6"
version = "1.4.7"
2 changes: 1 addition & 1 deletion dbt/adapters/exasol/connections.py
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ class ExasolCredentials(Credentials):
socket_timeout: int = pyexasol.constant.DEFAULT_SOCKET_TIMEOUT
query_timeout: int = pyexasol.constant.DEFAULT_QUERY_TIMEOUT
compression: bool = False
encryption: bool = False
encryption: bool = True
## Because of potential interference with dbt,
# the following statements are not (yet) implemented
# fetch_dict: bool
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "dbt-exasol"
version = "1.4.6"
version = "1.4.7"
description = "Adapter to dbt-core for warehouse Exasol"
authors = ["Torsten Glunde <torsten.glunde@alligator-company.com>", "Ilija Kutle <ilija.kutle@alligator-company.com>"]
homepage = "https://alligatorcompany.gitlab.io/dbt-exasol"
Expand Down
2 changes: 2 additions & 0 deletions test.env
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,5 @@ DBT_PASS=.
DBT_TEST_USER_1=dbt_test_role_1
DBT_TEST_USER_2=dbt_test_role_2
DBT_TEST_USER_3=dbt_test_role_3

EXASOL_RELEASE=8
5 changes: 4 additions & 1 deletion tests/functional/test_grants.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,10 @@ class TestIncrementalGrantsExasol(BaseIncrementalGrants):

class TestInvalidGrantsExasol(BaseInvalidGrants):
def grantee_does_not_exist_error(self):
return "user or role 'INVALID_USER' does not exist"
# Exasol versions have different error messages:
# Exasol 7: "user or role 'INVALID_USER does not exist"
# Exasol 8: "user or role INVALID_USER does not exist"
return "does not exist"

def privilege_does_not_exist_error(self):
return "syntax error, unexpected ON_, expecting ',' or TO_ [line 3, column 34]"
Expand Down

0 comments on commit dd88e45

Please sign in to comment.