Fix exception when retrieving mixed data types #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the first row of a column returned from Exasol was a decimal type then the adapter would expect all subsequent rows to be decimal and if one of them happened to be NULL it would throw an exception: "conversion from NoneType to Decimal is not supported" This commit fixes that.
|
Hi @peterkioko , thanks a lot for the effort, highly appreciated. I will take a look today and hopefully merge by tomorrow. Regards, Torsten |
tglunde
approved these changes
Nov 14, 2023
tglunde
pushed a commit
that referenced
this pull request
Nov 14, 2023
If the first row of a column returned from Exasol was a decimal type then the adapter would expect all subsequent rows to be decimal and if one of them happened to be NULL it would throw an exception: "conversion from NoneType to Decimal is not supported" This commit fixes that. Co-authored-by: Peter Kioko <kioko@grantstreet.com>
tglunde
pushed a commit
that referenced
this pull request
Nov 15, 2023
If the first row of a column returned from Exasol was a decimal type then the adapter would expect all subsequent rows to be decimal and if one of them happened to be NULL it would throw an exception: "conversion from NoneType to Decimal is not supported" This commit fixes that. Co-authored-by: Peter Kioko <kioko@grantstreet.com>
|
hi @peterkioko , bugfix releases for 1.4.6, 1.5.2 and 1.6.1 are published. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the first row of a column returned from Exasol was a decimal type then the adapter would expect all subsequent rows to be decimal and if one of them happened to be NULL it would throw an exception:
"conversion from NoneType to Decimal is not supported"
This commit fixes that.