Skip to content

Commit

Permalink
Disable non-empty nulls assertions (NVIDIA#1087)
Browse files Browse the repository at this point in the history 
* Disable non-empty nulls assertions

Signed-off-by: Raza Jafri <rjafri@nvidia.com>

* removed the wildcard from test name

Signed-off-by: Raza Jafri <rjafri@nvidia.com>

* upmerge

Signed-off-by: Raza Jafri <rjafri@nvidia.com>

---------

Signed-off-by: Raza Jafri <rjafri@nvidia.com>
  • Loading branch information
@razajafri
razajafri authored Apr 26, 2023
1 parent 3ec2292 commit 9bd78ca
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 4 deletions.
2 changes: 1 addition & 1 deletion ci/nightly-build.sh
View file
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,5 @@ ${MVN} clean package ${MVN_MIRROR} \
-Psource-javadoc \
-DCPP_PARALLEL_LEVEL=${PARALLEL_LEVEL} \
-Dlibcudf.build.configure=true \
-DUSE_GDS=${USE_GDS} -Dtest=*,!CuFileTest,!CudaFatalTest \
-DUSE_GDS=${USE_GDS} -Dtest=*,!CuFileTest,!CudaFatalTest,!ColumnViewNonEmptyNullsTest \
-DBUILD_TESTS=ON -Dcuda.version=$CUDA_VER
2 changes: 1 addition & 1 deletion ci/premerge-build.sh
View file
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,5 @@ PARALLEL_LEVEL=${PARALLEL_LEVEL:-4}
${MVN} verify ${MVN_MIRROR} \
-DCPP_PARALLEL_LEVEL=${PARALLEL_LEVEL} \
-Dlibcudf.build.configure=true \
-DUSE_GDS=ON -Dtest=*,!CuFileTest,!CudaFatalTest \
-DUSE_GDS=ON -Dtest=*,!CuFileTest,!CudaFatalTest,!ColumnViewNonEmptyNullsTest \
-DBUILD_TESTS=ON
2 changes: 1 addition & 1 deletion ci/submodule-sync.sh
View file
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ set +e
${MVN} verify ${MVN_MIRROR} \
-DCPP_PARALLEL_LEVEL=${PARALLEL_LEVEL} \
-Dlibcudf.build.configure=true \
-DUSE_GDS=ON -Dtest=*,!CuFileTest,!CudaFatalTest \
-DUSE_GDS=ON -Dtest=*,!CuFileTest,!CudaFatalTest,!ColumnViewNonEmptyNullsTest \
-DBUILD_TESTS=ON
verify_status=$?
set -e
Expand Down
11 changes: 11 additions & 0 deletions pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -535,9 +535,20 @@
<configuration>
<excludes>
<exclude>**/CudaFatalTest.java</exclude>
<exclude>**/ColumnViewNonEmptyNullsTest.java</exclude>
</excludes>
</configuration>
</execution>
<execution>
<id>non-empty-null-test</id>
<goals>
<goal>test</goal>
</goals>
<configuration>
<argLine>-da:ai.rapids.cudf.AssertEmptyNulls</argLine>
<test>ColumnViewNonEmptyNullsTest</test>
</configuration>
</execution>
<execution>
<id>fatal-cuda-test</id>
<goals>
Expand Down
2 changes: 1 addition & 1 deletion thirdparty/cudf
Submodule cudf updated 54 files
+8 −8 .github/workflows/build.yaml
+14 −14 .github/workflows/pr.yaml
+8 −8 .github/workflows/test.yaml
+1 −1 README.md
+1 −1 build.sh
+3 −3 conda/environments/all_cuda-118_arch-x86_64.yaml
+1 −1 conda/recipes/libcudf/conda_build_config.yaml
+1 −1 conda/recipes/libcudf/meta.yaml
+1 −0 cpp/CMakeLists.txt
+4 −4 cpp/benchmarks/CMakeLists.txt
+22 −0 cpp/benchmarks/fixture/nvbench_main.cpp
+0 −2 cpp/benchmarks/fixture/rmm_pool_raii.hpp
+2 −3 cpp/benchmarks/io/text/multibyte_split.cpp
+1 −1 cpp/cmake/thirdparty/patches/nvbench_global_setup.diff
+10 −1 cpp/include/cudf/detail/utilities/pinned_host_vector.hpp
+2 −2 cpp/include/cudf/io/detail/orc.hpp
+2 −2 cpp/include/cudf/io/detail/parquet.hpp
+2 −2 cpp/include/cudf/io/detail/utils.hpp
+77 −4 cpp/src/io/comp/nvcomp_adapter.cpp
+14 −1 cpp/src/io/comp/nvcomp_adapter.hpp
+4 −4 cpp/src/io/functions.cpp
+5 −1 cpp/src/io/orc/dict_enc.cu
+72 −96 cpp/src/io/orc/writer_impl.cu
+23 −23 cpp/src/io/orc/writer_impl.hpp
+16 −28 cpp/src/io/parquet/writer_impl.cu
+5 −5 cpp/src/io/parquet/writer_impl.hpp
+5 −8 cpp/src/io/text/bgzip_data_chunk_source.cu
+6 −11 cpp/src/io/text/data_chunk_source_factories.cpp
+22 −4 cpp/src/io/utilities/file_io_utilities.cpp
+3 −4 cpp/src/io/utilities/hostdevice_vector.hpp
+3 −3 cpp/src/io/utilities/trie.cu
+18 −156 cpp/src/search/contains_table.cu
+0 −85 cpp/src/stream_compaction/unique_count.cu
+110 −0 cpp/src/stream_compaction/unique_count_column.cu
+3 −7 dependencies.yaml
+2 −2 java/ci/build-in-docker.sh
+22 −6 java/pom.xml
+36 −0 java/src/main/java/ai/rapids/cudf/AssertEmptyNulls.java
+2 −0 java/src/main/java/ai/rapids/cudf/ColumnView.java
+13 −11 java/src/main/java/ai/rapids/cudf/Table.java
+60 −21 java/src/main/java/ai/rapids/cudf/WindowOptions.java
+13 −1 java/src/main/java/ai/rapids/cudf/ast/Literal.java
+37 −8 java/src/main/native/src/CompiledExpression.cpp
+32 −17 java/src/main/native/src/TableJni.cpp
+1 −99 java/src/test/java/ai/rapids/cudf/ColumnVectorTest.java
+134 −0 java/src/test/java/ai/rapids/cudf/ColumnViewNonEmptyNullsTest.java
+52 −0 java/src/test/java/ai/rapids/cudf/TableTest.java
+64 −1 java/src/test/java/ai/rapids/cudf/ast/CompiledExpressionTest.java
+1 −1 pyproject.toml
+1 −1 python/cudf/cudf/_lib/CMakeLists.txt
+2 −2 python/cudf/pyproject.toml
+1 −1 python/cudf_kafka/pyproject.toml
+1 −2 python/custreamz/pyproject.toml
+1 −2 python/dask_cudf/pyproject.toml

0 comments on commit 9bd78ca

Please sign in to comment.