Enable callback-return and fix issues (MetaMask#276)

Co-authored-by: Erik Marks <25517051+rekmarks@users.noreply.github.com>
thanhpn · Sep 11, 2020 · 2c24f74 · 2c24f74
1 parent af985eb
commit 2c24f74
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 1 deletion.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -47,7 +47,6 @@ module.exports = {
       },
     ],
 
-    'callback-return': 'off',
     'camelcase': 'off',
     'consistent-return': 'off',
     'default-case': 'off',

diff --git a/tests/TransactionController.test.ts b/tests/TransactionController.test.ts
@@ -13,6 +13,7 @@ jest.mock('eth-query', () =>
       estimateGas: (_transaction: any, callback: any) => {
         if (mockFlags.estimateGas) {
           callback(new Error(mockFlags.estimateGas));
+          return;
         }
         callback(undefined, '0x0');
       },