Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad links in all.jsonnet #242

Closed
aletessier opened this issue Aug 24, 2021 · 2 comments
Closed

Bad links in all.jsonnet #242

aletessier opened this issue Aug 24, 2021 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@aletessier
Copy link
Contributor

Links in example are broken. For example here:

kube-thanos/all.jsonnet

Line 113 in add27c3

// For DNS service discovery reference https://thanos.io/service-discovery.md/#dns-service-discovery

should be https://thanos.io/tip/thanos/service-discovery.md/#dns-service-discovery
@kakkoyun
Copy link
Member

Thanks for reporting :) Feel free to contribute 🤗

@kakkoyun kakkoyun added good first issue Good for newcomers help wanted Extra attention is needed labels Sep 15, 2021
@aletessier aletessier mentioned this issue Sep 15, 2021
Closed
2 tasks
aletessier added a commit to aletessier/kube-thanos that referenced this issue Sep 22, 2021
@aletessier
update dns discovery links (thanos-io#242)
bc4c58c 
Signed-off-by: Alexis Letessier <alexis.letessier@gmail.com>
yeya24 added a commit that referenced this issue Oct 4, 2021
@yeya24
Merge pull request #250 from aletessier/main
14b05c8 
update dns discovery links (#242)
@yeya24
Copy link
Contributor

yeya24 commented Oct 4, 2021

Closed by #250

@yeya24 yeya24 closed this as completed Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update DNS SD links #242
3 participants
@aletessier @kakkoyun @yeya24