Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tc.config.replicas variable in compact component. #109

Merged
merged 1 commit into from
Apr 7, 2020

Conversation

metalmatze
Copy link
Contributor

While we shouldn't run multiple compactors at once, we still might want
to run 1 or 0 replicas.

Signed-off-by: Matthias Loibl mail@matthiasloibl.com

/cc @brancz @kakkoyun

This blocks observatorium/observatorium#244 where we set compact.replicas correctly but it doesn't get picked up...

While we shouldn't run multiple compactors at once, we still might want
to run 1 or 0 replicas.

Signed-off-by: Matthias Loibl <mail@matthiasloibl.com>
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brancz brancz merged commit a203682 into thanos-io:master Apr 7, 2020
@metalmatze metalmatze deleted the compact-replicas branch April 7, 2020 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants