Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support alertmanager configuration and extra volumes for thanos ruler. #225

Merged
merged 2 commits into from
Jan 5, 2022
Merged

support alertmanager configuration and extra volumes for thanos ruler. #225

merged 2 commits into from
Jan 5, 2022

Conversation

morvencao
Copy link
Contributor

@morvencao morvencao commented May 10, 2021 •
edited
Loading

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Verification

@morvencao
Copy link
Contributor Author

morvencao commented May 10, 2021 •
edited
Loading

/cc @squat

@morvencao morvencao closed this Jun 10, 2021
@morvencao morvencao deleted the br_su_support_alertmanager_configure branch June 10, 2021 07:31
@morvencao morvencao restored the br_su_support_alertmanager_configure branch January 4, 2022 09:13
@morvencao morvencao reopened this Jan 4, 2022
@clyang82
Copy link
Contributor

clyang82 commented Jan 5, 2022

cc @kakkoyun @metalmatze

@metalmatze
Copy link
Contributor

LGTM if it works!

@kakkoyun
Copy link
Member

kakkoyun commented Jan 5, 2022

Same here. It would be great if you could attach generated examples for the changes.

@morvencao
add test alerting configuration.
319dd3c 
Signed-off-by: morvencao <lcao@redhat.com>
@morvencao
Copy link
Contributor Author

@kakkoyun Another look^^ just added testing alerting configuration.

kakkoyun
kakkoyun approved these changes Jan 5, 2022
View reviewed changes
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kakkoyun kakkoyun merged commit 19e913d into thanos-io:main Jan 5, 2022
@morvencao morvencao deleted the br_su_support_alertmanager_configure branch January 5, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kakkoyun kakkoyun kakkoyun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@morvencao @clyang82 @metalmatze @kakkoyun