example: Fix missing common resources for (compact|store)-shards/receive-hashrings #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxbrunet
force-pushed
the
feature/hide-non-resource-fields
branch
2 times, most recently
from
476a747
to
c0723aa
Compare
|
On an afterthought, hiding keys could potentially annoy some people like Tanka users which extracts Kubernetes resources from any level as long as they are not hidden, so I am just going to fix the example by looping and filtering out these keys. |
maxbrunet
changed the title
maxbrunet
force-pushed
the
feature/hide-non-resource-fields
branch
from
c0723aa
to
0a5a829
Compare
Signed-off-by: Maxime Brunet <maxime.brunet@paytm.com>
Signed-off-by: Maxime Brunet <maxime.brunet@paytm.com>
maxbrunet
force-pushed
the
feature/hide-non-resource-fields
branch
from
0a5a829
to
8c6611f
Compare
maxbrunet
changed the title
kakkoyun
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Hidehashringsandshardsfields inthanos-receive-hashringsandstore-shards.This allows to loop through them like the others instead of hand-picking resources and risking missing them (like the service accounts) or having a condition in the loop (e.g.
if name != 'shards').Loop through
compact-shards,receive-hashringsandstore-shardscommon resources and conditionally skip non-resource fields.Verification
Generated manifests are still the same and service accounts are now here