Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make receiver cluster domain name configurable #249

Merged
merged 1 commit into from
Nov 11, 2021

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Sep 22, 2021

Signed-off-by: Ben Ye ben.ye@bytedance.com

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

We have this use case as the cluster domain name is not cluster.local.

Verification

Signed-off-by: Ben Ye <ben.ye@bytedance.com>
@yeya24 yeya24 force-pushed the receive-configurable-domain branch from a76d006 to 8c8b810 Compare October 4, 2021 03:43
@yeya24
Copy link
Contributor Author

yeya24 commented Nov 8, 2021

Any idea why circle CI fails running? @kakkoyun
Is it better to fully migrate to Github actions?

@yeya24
Copy link
Contributor Author

yeya24 commented Nov 11, 2021

I will merge this one as it is a tiny change.

@yeya24 yeya24 merged commit b45cbba into main Nov 11, 2021
@yeya24 yeya24 deleted the receive-configurable-domain branch November 11, 2021 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant