Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra env vars to all components deployed with kube-thanos #251

Merged
merged 4 commits into from
Oct 4, 2021

Conversation

mwasilew2
Copy link
Contributor

@mwasilew2 mwasilew2 commented Sep 27, 2021

closes: #246

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

  • format the env section of kube-thanos-store.libsonnet
  • add support for extraEnv (adding custom environment variables) to all kube-thanos components
  • changelog entry

Verification

to test this change I edited the default values for a few components (not all!) and added the following:


          {
            name: 'JAEGER_DISABLED',
            value: 'false',
          },
          {
            name: 'JAEGER_SAMPLER_TYPE',
            value: 'probabilistic',
          },
          {
            name: 'JAEGER_SAMPLER_PARAM',
            value: '0.01',
          },
          {
            name: 'JAEGER_AGENT_HOST',
            valueFrom: {
              fieldRef: {
                fieldPath: 'status.hostIP',
              },
            },
          },

I then run make all which includes automated verification of validity of generated k8s yaml files. I also eye-balled the generated files in ./examples and ./manifests to see if they looked as expected

Signed-off-by: Michal Wasilewski <mwasilewski@gmx.com>
Signed-off-by: Michal Wasilewski <mwasilewski@gmx.com>
Signed-off-by: Michal Wasilewski <mwasilewski@gmx.com>
Signed-off-by: Michal Wasilewski <mwasilewski@gmx.com>
@mwasilew2 mwasilew2 marked this pull request as ready for review September 27, 2021 16:02
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM!

@yeya24 yeya24 merged commit fdba356 into thanos-io:main Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add extraEnv to all containers to make injection of custom env vars easier
2 participants