Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support stateless Ruler #263

Merged
merged 2 commits into from
Feb 8, 2022
Merged

Support stateless Ruler #263

merged 2 commits into from
Feb 8, 2022

Conversation

saswatamcode
Copy link
Member

@saswatamcode saswatamcode commented Feb 8, 2022 •
edited
Loading

This PR adds support for running Stateless Rulers using kube-thanos.

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

  • Adds option remoteWriteConfigFile to defaults in kube-thanos-rule.libsonnet
  • Modifies all.jsonnet to use newly added option

Verification

Tested locally.

@saswatamcode
Support stateless Ruler
002c8a8 
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
@saswatamcode
Add CHANGELOG
e401391 
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
yeya24
yeya24 approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yeya24 yeya24 merged commit 336482e into thanos-io:main Feb 8, 2022
@chipzzz chipzzz mentioned this pull request Feb 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeya24 yeya24 yeya24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saswatamcode @yeya24