Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option for enabling new PromQL engine in querier #285

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Add option for enabling new PromQL engine in querier #285

merged 1 commit into from
Oct 10, 2022

Conversation

saswatamcode
Copy link
Member

This PR adds a useThanosEngine option for enabling the new PromQL engine in Thanos Querier. Set to false by default.

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

  • Add useThanosEngine option which is false by default.

Verification

Tested locally.

@saswatamcode
Add option for enabling new PromQL engine in querier
3f2c658 
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
yeya24
yeya24 approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yeya24 yeya24 merged commit e57d153 into thanos-io:main Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@periklis periklis periklis approved these changes

@yeya24 yeya24 yeya24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saswatamcode @periklis @yeya24