Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kube-thanos: Filter emptyDir instead of resetting volumes with PVC #96

Merged
merged 1 commit into from
Feb 11, 2020
Merged

kube-thanos: Filter emptyDir instead of resetting volumes with PVC #96

merged 1 commit into from
Feb 11, 2020

Conversation

brancz
Copy link
Member

@brancz brancz commented Feb 11, 2020

bwplotka
bwplotka approved these changes Feb 11, 2020
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is where types would help IMO (:

LGTM

squat
squat approved these changes Feb 11, 2020
View reviewed changes
Copy link
Member

@squat squat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :) please sign the DCO :p

@brancz
Copy link
Member Author

brancz commented Feb 11, 2020

This is where types would help IMO (:

This problem would have occurred in Go just as much. This was just a mistake in code.

@brancz
kube-thanos: Filter emptyDir instead of resetting volumes with PVC
b9cff03 
Signed-off-by: Frederic Branczyk <fbranczyk@gmail.com>
@brancz brancz merged commit 6f490d7 into master Feb 11, 2020
@brancz brancz deleted the filter-pvc-empty-dir branch February 11, 2020 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwplotka bwplotka bwplotka approved these changes

@squat squat squat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brancz @bwplotka @squat