Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift: Allow authentication via application credentials #32

Merged
merged 2 commits into from
Dec 5, 2022

Conversation

aarnq
Copy link
Contributor

@aarnq aarnq commented Oct 25, 2022

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Adds the option to authenticate with application credentials when using Swift.

Verification

Built and tested with a local version of Thanos verifying using the tools bucket commands, and set up a full dev deployment that is currently running.

@aarnq aarnq force-pushed the swift/application-credentials branch 2 times, most recently from f3909e0 to 3f45a62 Compare October 27, 2022 05:59
Signed-off-by: André Arnqvist <andre.arnqvist@elastisys.com>
@aarnq aarnq force-pushed the swift/application-credentials branch from 3f45a62 to 2f7ab58 Compare November 29, 2022 15:00
@aarnq
Copy link
Contributor Author

aarnq commented Dec 1, 2022

Hi @FUSAKLA could you please take a look at these changes?
Thanks!

@FUSAKLA
Copy link
Member

FUSAKLA commented Dec 1, 2022

Hi, great 👍 from me, thanks!

Just one more thing, the configuration options are in the docs. I believe this is generated dynamically, so you should be able to update it by running make docs IIRC 🤔

@aarnq
Copy link
Contributor Author

aarnq commented Dec 2, 2022

Hi, great +1 from me, thanks!

Just one more thing, the configuration options are in the docs. I believe this is generated dynamically, so you should be able to update it by running make docs IIRC thinking

Thank you for taking a look at it!

I have done those steps, it at least updated the readme in this repo. I assume that is later used in the main repo for storage.md. Do you want me add more to it about how to authenticate with application credentials?

@FUSAKLA
Copy link
Member

FUSAKLA commented Dec 5, 2022

In the next PR to bump the dependency on this package, you'll need to run the docs update also, I think.
Regarding documentation of the fields, other fields are not documented either, and I think it's quite self-explanatory and easy to find in Swift documentation.

From me, it is 👍 thanks 🎉

I do not have the rights to merge this, so maybe @bwplotka could help? 🙏

@squat squat enabled auto-merge (squash) December 5, 2022 13:16
@squat squat merged commit 5aafc00 into thanos-io:main Dec 5, 2022
@FUSAKLA
Copy link
Member

FUSAKLA commented Dec 5, 2022

Thanks @squat !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants