Skip to content

Commit

Permalink
Update go_grpc_middleware to v2.0.0
Browse files Browse the repository at this point in the history
Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>
  • Loading branch information
coleenquadros committed Oct 18, 2023
1 parent 86f00af commit 3cd80ca
Show file tree
Hide file tree
Showing 40 changed files with 4,474 additions and 283 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ We use *breaking :warning:* to mark changes that are not backward compatible (re
- [#6765](https://github.com/thanos-io/thanos/pull/6765) Index Cache: Add `enabled_items` to index cache config to selectively cache configured items. Available item types are `Postings`, `Series` and `ExpandedPostings`.
- [#6773](https://github.com/thanos-io/thanos/pull/6773) Index Cache: Add `ttl` to control the ttl to store items in remote index caches like memcached and redis.


### Changed

- [#6698](https://github.com/thanos-io/thanos/pull/6608) Receive: Change write log level from warn to info.
Expand Down
6 changes: 4 additions & 2 deletions cmd/thanos/query.go
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ func registerQuery(app *extkingpin.App) {
return errors.Wrap(err, "error while parsing config for request logging")
}

grpcLogOpts, err := logging.ParsegRPCOptions(reqLogConfig)
grpcLogOpts, logFilterMethods, err := logging.ParsegRPCOptions(reqLogConfig)

if err != nil {
return errors.Wrap(err, "error while parsing config for request logging")
Expand Down Expand Up @@ -278,6 +278,7 @@ func registerQuery(app *extkingpin.App) {
tracer,
httpLogOpts,
grpcLogOpts,
logFilterMethods,
grpcServerConfig,
*grpcCompression,
*secure,
Expand Down Expand Up @@ -356,6 +357,7 @@ func runQuery(
tracer opentracing.Tracer,
httpLogOpts []logging.Option,
grpcLogOpts []grpc_logging.Option,
logFilterMethods []string,
grpcServerConfig grpcConfig,
grpcCompression string,
secure bool,
Expand Down Expand Up @@ -812,7 +814,7 @@ func runQuery(
defaultEngineType := querypb.EngineType(querypb.EngineType_value[defaultEngine])
grpcAPI := apiv1.NewGRPCAPI(time.Now, queryReplicaLabels, queryableCreator, engineFactory, defaultEngineType, lookbackDeltaCreator, instantDefaultMaxSourceResolution)
storeServer := store.NewLimitedStoreServer(store.NewInstrumentedStoreServer(reg, proxy), reg, storeRateLimits)
s := grpcserver.New(logger, reg, tracer, grpcLogOpts, comp, grpcProbe,
s := grpcserver.New(logger, reg, tracer, grpcLogOpts, logFilterMethods, comp, grpcProbe,
grpcserver.WithServer(apiv1.RegisterQueryServer(grpcAPI)),
grpcserver.WithServer(store.RegisterStoreServer(storeServer, logger)),
grpcserver.WithServer(rules.RegisterRulesServer(rulesProxy)),
Expand Down
6 changes: 4 additions & 2 deletions cmd/thanos/receive.go
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ func registerReceive(app *extkingpin.App) {
return errors.New("no external labels configured for receive, uniquely identifying external labels must be configured (ideally with `receive_` prefix); see https://thanos.io/tip/thanos/storage.md#external-labels for details.")
}

grpcLogOpts, err := logging.ParsegRPCOptions(conf.reqLogConfig)
grpcLogOpts, logFilterMethods, err := logging.ParsegRPCOptions(conf.reqLogConfig)

if err != nil {
return errors.Wrap(err, "error while parsing config for request logging")
Expand Down Expand Up @@ -104,6 +104,7 @@ func registerReceive(app *extkingpin.App) {
reg,
tracer,
grpcLogOpts,
logFilterMethods,
tsdbOpts,
lset,
component.Receive,
Expand All @@ -121,6 +122,7 @@ func runReceive(
reg *prometheus.Registry,
tracer opentracing.Tracer,
grpcLogOpts []grpc_logging.Option,
logFilterMethods []string,
tsdbOpts *tsdb.Options,
lset labels.Labels,
comp component.SourceStoreAPI,
Expand Down Expand Up @@ -354,7 +356,7 @@ func runReceive(
info.WithExemplarsInfoFunc(),
)

srv := grpcserver.New(logger, receive.NewUnRegisterer(reg), tracer, grpcLogOpts, comp, grpcProbe,
srv := grpcserver.New(logger, receive.NewUnRegisterer(reg), tracer, grpcLogOpts, logFilterMethods, comp, grpcProbe,
grpcserver.WithServer(store.RegisterStoreServer(rw, logger)),
grpcserver.WithServer(store.RegisterWritableStoreServer(rw)),
grpcserver.WithServer(exemplars.RegisterExemplarsServer(exemplars.NewMultiTSDB(dbs.TSDBExemplars))),
Expand Down
6 changes: 4 additions & 2 deletions cmd/thanos/rule.go
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ func registerRule(app *extkingpin.App) {
return errors.Wrap(err, "error while parsing config for request logging")
}

grpcLogOpts, err := logging.ParsegRPCOptions(reqLogConfig)
grpcLogOpts, logFilterMethods, err := logging.ParsegRPCOptions(reqLogConfig)

if err != nil {
return errors.Wrap(err, "error while parsing config for request logging")
Expand All @@ -234,6 +234,7 @@ func registerRule(app *extkingpin.App) {
getFlagsMap(cmd.Flags()),
httpLogOpts,
grpcLogOpts,
logFilterMethods,
tsdbOpts,
agentOpts,
)
Expand Down Expand Up @@ -297,6 +298,7 @@ func runRule(
flagsMap map[string]string,
httpLogOpts []logging.Option,
grpcLogOpts []grpc_logging.Option,
logFilterMethods []string,
tsdbOpts *tsdb.Options,
agentOpts *agent.Options,
) error {
Expand Down Expand Up @@ -659,7 +661,7 @@ func runRule(
options = append(options, grpcserver.WithServer(
info.RegisterInfoServer(info.NewInfoServer(component.Rule.String(), infoOptions...)),
))
s := grpcserver.New(logger, reg, tracer, grpcLogOpts, comp, grpcProbe, options...)
s := grpcserver.New(logger, reg, tracer, grpcLogOpts, logFilterMethods, comp, grpcProbe, options...)

g.Add(func() error {
statusProber.Ready()
Expand Down
7 changes: 4 additions & 3 deletions cmd/thanos/sidecar.go
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ func registerSidecar(app *extkingpin.App) {
conf.registerFlag(cmd)
cmd.Setup(func(g *run.Group, logger log.Logger, reg *prometheus.Registry, tracer opentracing.Tracer, _ <-chan struct{}, _ bool) error {

grpcLogOpts, err := logging.ParsegRPCOptions(conf.reqLogConfig)
grpcLogOpts, logFilterMethods, err := logging.ParsegRPCOptions(conf.reqLogConfig)

if err != nil {
return errors.Wrap(err, "error while parsing config for request logging")
Expand All @@ -74,7 +74,7 @@ func registerSidecar(app *extkingpin.App) {
RetryInterval: conf.reloader.retryInterval,
})

return runSidecar(g, logger, reg, tracer, rl, component.Sidecar, *conf, grpcLogOpts)
return runSidecar(g, logger, reg, tracer, rl, component.Sidecar, *conf, grpcLogOpts, logFilterMethods)
})
}

Expand All @@ -87,6 +87,7 @@ func runSidecar(
comp component.Component,
conf sidecarConfig,
grpcLogOpts []grpc_logging.Option,
logFilterMethods []string,
) error {
httpConfContentYaml, err := conf.prometheus.httpClient.Content()
if err != nil {
Expand Down Expand Up @@ -287,7 +288,7 @@ func runSidecar(
)

storeServer := store.NewLimitedStoreServer(store.NewInstrumentedStoreServer(reg, promStore), reg, conf.storeRateLimits)
s := grpcserver.New(logger, reg, tracer, grpcLogOpts, comp, grpcProbe,
s := grpcserver.New(logger, reg, tracer, grpcLogOpts, logFilterMethods, comp, grpcProbe,
grpcserver.WithServer(store.RegisterStoreServer(storeServer, logger)),
grpcserver.WithServer(rules.RegisterRulesServer(rules.NewPrometheus(conf.prometheus.url, c, m.Labels))),
grpcserver.WithServer(targets.RegisterTargetsServer(targets.NewPrometheus(conf.prometheus.url, c, m.Labels))),
Expand Down
6 changes: 4 additions & 2 deletions cmd/thanos/store.go
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ func registerStore(app *extkingpin.App) {
return errors.Wrap(err, "error while parsing config for request logging")
}

grpcLogOpts, err := logging.ParsegRPCOptions(conf.reqLogConfig)
grpcLogOpts, logFilterMethods, err := logging.ParsegRPCOptions(conf.reqLogConfig)

if err != nil {
return errors.Wrap(err, "error while parsing config for request logging")
Expand All @@ -233,6 +233,7 @@ func registerStore(app *extkingpin.App) {
tracer,
httpLogOpts,
grpcLogOpts,
logFilterMethods,
*conf,
getFlagsMap(cmd.Flags()),
)
Expand All @@ -247,6 +248,7 @@ func runStore(
tracer opentracing.Tracer,
httpLogOpts []logging.Option,
grpcLogOpts []grpclogging.Option,
logFilterMethods []string,
conf storeConfig,
flagsMap map[string]string,
) error {
Expand Down Expand Up @@ -480,7 +482,7 @@ func runStore(
}

storeServer := store.NewInstrumentedStoreServer(reg, bs)
s := grpcserver.New(logger, reg, tracer, grpcLogOpts, conf.component, grpcProbe,
s := grpcserver.New(logger, reg, tracer, grpcLogOpts, logFilterMethods, conf.component, grpcProbe,
grpcserver.WithServer(store.RegisterStoreServer(storeServer, logger)),
grpcserver.WithServer(info.RegisterInfoServer(infoSrv)),
grpcserver.WithListen(conf.grpcConfig.bindAddress),
Expand Down
7 changes: 3 additions & 4 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,7 @@ require (
github.com/googleapis/gax-go v2.0.2+incompatible
github.com/gorilla/mux v1.8.0 // indirect
github.com/grafana/regexp v0.0.0-20221122212121-6b5c0a4cb7fd // indirect
github.com/grpc-ecosystem/go-grpc-middleware v1.3.0 // indirect
github.com/grpc-ecosystem/go-grpc-middleware/providers/kit/v2 v2.0.0-20201002093600-73cf2ae9d891
github.com/grpc-ecosystem/go-grpc-middleware/v2 v2.0.0-rc.2.0.20201207153454-9f6bf00c00a7
github.com/grpc-ecosystem/go-grpc-middleware/v2 v2.0.0
github.com/grpc-ecosystem/go-grpc-prometheus v1.2.0
github.com/hashicorp/golang-lru v0.6.0
github.com/jpillora/backoff v1.0.0
Expand Down Expand Up @@ -124,8 +122,10 @@ require (
)

require (
github.com/HdrHistogram/hdrhistogram-go v1.1.2 // indirect
github.com/golang-jwt/jwt/v5 v5.0.0 // indirect
github.com/google/s2a-go v0.1.4 // indirect
github.com/grpc-ecosystem/go-grpc-middleware v1.3.0 // indirect
github.com/huaweicloud/huaweicloud-sdk-go-obs v3.23.3+incompatible // indirect
github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect
github.com/onsi/ginkgo v1.16.5 // indirect
Expand Down Expand Up @@ -171,7 +171,6 @@ require (
github.com/elastic/go-sysinfo v1.8.1 // indirect
github.com/elastic/go-windows v1.0.1 // indirect
github.com/felixge/httpsnoop v1.0.3 // indirect
github.com/go-kit/kit v0.12.0 // indirect
github.com/go-logfmt/logfmt v0.6.0 // indirect
github.com/go-logr/logr v1.2.4 // indirect
github.com/go-logr/stdr v1.2.2 // indirect
Expand Down
Loading

0 comments on commit 3cd80ca

Please sign in to comment.