query-frontend: Handling logging for code 3xx (#3181)

* added info level logging for code [300-400) Signed-off-by: aribalam <arib.alam.iitkgp@gmail.com> * changed to debug level for responses between [200, 500) Signed-off-by: aribalam <arib.alam.iitkgp@gmail.com> * updated changelog Signed-off-by: aribalam <arib.alam.iitkgp@gmail.com> * changed changelog title Signed-off-by: aribalam <arib.alam.iitkgp@gmail.com>
thanos-io · Sep 18, 2020 · 5f5b15e · 5f5b15e
1 parent 727a351
commit 5f5b15e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -13,6 +13,7 @@ We use *breaking :warning:* to mark changes that are not backward compatible (re
 
 ### Added
 
+- [#3181](https://github.com/thanos-io/thanos/pull/3181) Logging: Add debug level logging for responses between 300-399
 - [#3133](https://github.com/thanos-io/thanos/pull/3133) Query: Allow passing a `storeMatch[]` to Labels APIs. Also time range metadata based store filtering is supported on Labels APIs.
 - [#3154](https://github.com/thanos-io/thanos/pull/3154) Query Frontend: Add metric `thanos_memcached_getmulti_gate_queries_max`.
 - [#3146](https://github.com/thanos-io/thanos/pull/3146) Sidecar: Add `thanos_sidecar_prometheus_store_received_frames` histogram metric.

diff --git a/pkg/logging/options.go b/pkg/logging/options.go
@@ -95,10 +95,7 @@ type options struct {
 
 // DefaultCodeToLevel is the helper mapper that maps HTTP Response codes to log levels.
 func DefaultCodeToLevel(logger log.Logger, code int) log.Logger {
-	if code >= 200 && code < 300 {
-		return level.Debug(logger)
-	}
-	if code >= 400 && code < 500 {
+	if code >= 200 && code < 500 {
 		return level.Debug(logger)
 	}
 	return level.Error(logger)