Skip to content

Commit

Permalink
Moved CI to build Thanos with golang 1.12.5 (#1156)
Browse files Browse the repository at this point in the history
This is to mitigate potential memory allocation latency bugs: prometheus/prometheus#5524

Signed-off-by: Bartek Plotka <bwplotka@gmail.com>

# Conflicts:
#	CHANGELOG.md
  • Loading branch information
bwplotka authored and brancz committed May 17, 2019
1 parent 02ce8af commit 6a72b1d
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
6 changes: 3 additions & 3 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ jobs:
test:
docker:
# Available from https://hub.docker.com/r/circleci/golang/
- image: circleci/golang:1.12
- image: circleci/golang:1.12.5
working_directory: /go/src/github.com/improbable-eng/thanos
environment:
GO111MODULE: 'on'
Expand Down Expand Up @@ -62,7 +62,7 @@ jobs:
publish_master:
docker:
# Available from https://hub.docker.com/r/circleci/golang/
- image: circleci/golang:1.12
- image: circleci/golang:1.12.5
working_directory: /go/src/github.com/improbable-eng/thanos
environment:
GOBIN: "/go/bin"
Expand All @@ -81,7 +81,7 @@ jobs:
publish_release:
docker:
# Available from https://hub.docker.com/r/circleci/golang/
- image: circleci/golang:1.12
- image: circleci/golang:1.12.5
working_directory: /go/src/github.com/improbable-eng/thanos
environment:
GOBIN: "/go/bin"
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ We use *breaking* word for marking changes that are not backward compatible (rel
- [ENHANCEMENT] Improve rule views by wrapping lines [PR #4702](https://github.com/prometheus/prometheus/pull/4702)
- [ENHANCEMENT] Show rule evaluation errors on rules page [PR #4457](https://github.com/prometheus/prometheus/pull/4457)

- [#1156](https://github.com/improbable-eng/thanos/pull/1156) Moved CI and docker multistage to Golang 1.12.5 for latest mem alloc improvements.

## [v0.4.0](https://github.com/improbable-eng/thanos/releases/tag/v0.4.0) - 2019.05.3

:warning: **IMPORTANT** :warning: This is the last release that supports gossip. From Thanos v0.5.0, gossip will be completely removed.
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile.multi-stage
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.12-alpine3.9 as builder
FROM golang:1.12.5-alpine3.9 as builder

ADD . $GOPATH/src/github.com/improbable-eng/thanos
WORKDIR $GOPATH/src/github.com/improbable-eng/thanos
Expand Down

0 comments on commit 6a72b1d

Please sign in to comment.