Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Replicate can copy individual blocks #2713

Closed
maulikjs opened this issue Jun 3, 2020 · 12 comments · Fixed by #3388
Closed

Feature Request: Replicate can copy individual blocks #2713

maulikjs opened this issue Jun 3, 2020 · 12 comments · Fixed by #3388

Comments

@maulikjs
Copy link

maulikjs commented Jun 3, 2020

So today we faced an issue where a few blocks were not copied to our destination bucket and I had to manually copy them over, I am still trying to figure out what went wrong but it would be a nice feature to have if the replicate can copy individual blocks over.

One another feature that would be really useful is to verify if all the blocks have been copied over between 2 buckets and maybe give a report for those which might have been missed.

@yeya24
Copy link
Contributor

yeya24 commented Jun 3, 2020

I think the first feature is nice and we can support it easily.

@bwplotka
Copy link
Member

bwplotka commented Jun 3, 2020 via email

@stale
Copy link

stale bot commented Jul 3, 2020

Hello 👋 Looks like there was no activity on this issue for last 30 days.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity for next week, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Jul 3, 2020
@stale
Copy link

stale bot commented Jul 10, 2020

Closing for now as promised, let us know if you need this to be reopened! 🤗

@stale stale bot closed this as completed Jul 10, 2020
@bwplotka
Copy link
Member

Lets get back on this. Help wanted!

@bwplotka bwplotka reopened this Jul 13, 2020
@stale stale bot removed the stale label Jul 13, 2020
@yeya24
Copy link
Contributor

yeya24 commented Jul 20, 2020

I can take this one if no one is on it. This feature can be implemented by adding specified blocks ID to blockFilter https://github.com/thanos-io/thanos/blob/master/pkg/replicate/scheme.go#L30.

@stale
Copy link

stale bot commented Aug 19, 2020

Hello 👋 Looks like there was no activity on this issue for last 30 days.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity for next week, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Aug 19, 2020
@yeya24
Copy link
Contributor

yeya24 commented Aug 19, 2020

Still on it. Blocked by #2906

@stale stale bot removed the stale label Aug 19, 2020
@stale
Copy link

stale bot commented Oct 18, 2020

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Oct 18, 2020
@kakkoyun kakkoyun removed the stale label Oct 19, 2020
@kakkoyun
Copy link
Member

@yeya24 Can we do anything to unblock #2906?

@yeya24
Copy link
Contributor

yeya24 commented Oct 19, 2020

@kakkoyun Please help review #2906

@yeya24
Copy link
Contributor

yeya24 commented Oct 30, 2020

Will take this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants