Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate closing grpc listener #1322

Merged
merged 1 commit into from
Jul 12, 2019

Conversation

jojohappy
Copy link
Member

Signed-off-by: jojohappy sarahdj0917@gmail.com

Changes

Remove the code runutil.CloseWithLogOnErr(logger, l, "store gRPC listener"), because when the grpc server is stopped, the listener who grpc server served will be closed too.

Verification

Send SIGHUP to the thanos components, such as query, store, sidecar. No warning log appeared like this:
level=warn ts=2019-07-12T04:20:03.867228785Z caller=runutil.go:108 component=sidecar msg="detected close error" err="store gRPC listener: close tcp 0.0.0.0:10901: use of closed network connection"

Signed-off-by: jojohappy <sarahdj0917@gmail.com>
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks!

Copy link
Member

@GiedriusS GiedriusS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@GiedriusS GiedriusS merged commit 7b36de5 into thanos-io:master Jul 12, 2019
GiedriusS added a commit to GiedriusS/thanos that referenced this pull request Jul 12, 2019
@jojohappy jojohappy deleted the remove_duplicate_closer branch August 21, 2019 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants