receive: Hash-ring metrics #1363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @brancz |
bwplotka
reviewed
Aug 5, 2019
| Name: "thanos_receive_hashring_tenants", | ||
| Help: "The number of tenants per hashring.", | ||
| }, | ||
| []string{"name"}), |
There was a problem hiding this comment.
Just curious on cardinality of this - this change on restart time or is fairly consistent across restarts?
There was a problem hiding this comment.
This is consistent across restarts. Name comes from a manually maintained list which is fed through a configuration file.
bwplotka
approved these changes
Aug 5, 2019
| @@ -75,6 +77,18 @@ func NewConfigWatcher(logger log.Logger, r prometheus.Registerer, path string, i | |||
| Name: "thanos_receive_hashrings_file_refreshes_total", | |||
| Help: "The number of refreshes of the hashrings configuration file.", | |||
| }), | |||
| hashringNodesGauge: prometheus.NewGaugeVec( | |||
| prometheus.GaugeOpts{ | |||
| Name: "thanos_receive_hashring_nodes", | |||
There was a problem hiding this comment.
nodes or endpoints? (: Don't have strong opinion.
| Name: "thanos_receive_hashring_tenants", | ||
| Help: "The number of tenants per hashring.", | ||
| }, | ||
| []string{"name"}), | ||
| } | ||
|
|
||
| if r != nil { |
There was a problem hiding this comment.
I think those metrics will work bit better if we would register them below ^^
There was a problem hiding this comment.
🤦♂ Thanks for pointing that out.
bwplotka
approved these changes
Aug 5, 2019
brancz
approved these changes
Aug 5, 2019
paulfantom
added a commit
to paulfantom/thanos
that referenced
this pull request
Aug 7, 2019
* master: iter.go: error message typo correction (thanos-io#1376) Fix usage of $GOPATH in Makefile (thanos-io#1379) Moved Prometheus 2.11.1 and TSDB to 0.9.1 (thanos-io#1380) Store latest config hash and timestamp as metrics (thanos-io#1378) pkg/receive/handler.go: log errors (thanos-io#1372) receive: Hash-ring metrics (thanos-io#1363) receiver: avoid race of hashring (thanos-io#1371) feat compact: added readiness Prober (thanos-io#1297) Add changelog entry for S3 option (thanos-io#1361) Multipart features (thanos-io#1358) Added katacoda.yaml (thanos-io#1359) Remove deprecated option from example (thanos-io#1351) Move suggestion about admin API to appropriate place (thanos-io#1355)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new metrics to monitor hash-rings.
It exposes the number of nodes and the number of tenants per hash-rings.
Changes
thanos_receive_hashring_nodesandthanos_receive_hashring_tenants.Verification
By using make test and manual testing against receive API, it seems like the previous behavior kept intact.