Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keep same logic with prometheus resend delay configuration #1612

Merged
merged 1 commit into from
Oct 8, 2019
Merged

keep same logic with prometheus resend delay configuration #1612

merged 1 commit into from
Oct 8, 2019

Conversation

00arthur00
Copy link
Contributor

@00arthur00 00arthur00 commented Oct 8, 2019 •
edited
Loading

keep same logic with prometheus resend delay configuration and EndsAt time

@00arthur00
keep same logic with prometheus resend delay configuration
a54c7c9 
Signed-off-by: 00arthur00 <yang_yapo@126.com>
bwplotka
bwplotka reviewed Oct 8, 2019
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think it makes sense 👍

Thanks!

@bwplotka bwplotka merged commit f5c11d7 into thanos-io:master Oct 8, 2019
GiedriusS pushed a commit that referenced this pull request Oct 28, 2019
@00arthur00 @GiedriusS
keep same logic with prometheus resend delay configuration (#1612)
6662eaf 
Signed-off-by: 00arthur00 <yang_yapo@126.com>
Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwplotka bwplotka bwplotka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@00arthur00 @bwplotka