Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rule UI #1854

Merged
merged 3 commits into from
Dec 10, 2019
Merged

Update rule UI #1854

merged 3 commits into from
Dec 10, 2019

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Dec 9, 2019 •
edited
Loading

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Sync with the classic Prometheus UI alerts page. Enable to display the alerts counts and filter by alert state.

Verification

image

@yeya24
update rule ui
5a710ae 
Signed-off-by: yeya24 <yb532204897@gmail.com>
@yeya24
typo fix
efbf137 
Signed-off-by: yeya24 <yb532204897@gmail.com>
@yeya24 yeya24 changed the title Update rule UI with Prometheus Update rule UI Dec 9, 2019
bwplotka
bwplotka approved these changes Dec 9, 2019
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add CHANGELOG and LGTM (:

Thanks for this!

@yeya24
update changelog
5a39261 
Signed-off-by: yeya24 <yb532204897@gmail.com>
@yeya24
Copy link
Contributor Author

yeya24 commented Dec 9, 2019

@bwplotka Done

bwplotka
bwplotka approved these changes Dec 10, 2019
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bwplotka bwplotka merged commit e94478c into thanos-io:master Dec 10, 2019
@yeya24 yeya24 deleted the update-rule-ui branch December 10, 2019 01:31
@yeya24 yeya24 mentioned this pull request Jan 25, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwplotka bwplotka bwplotka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yeya24 @bwplotka