Rename components #1891
Rename components #1891
Conversation
yeya24
force-pushed
the
rename
branch
3 times, most recently
from
817ac9e
to
3109975
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue/PR has been automatically marked as stale because it has not had recent activity. Please comment on status otherwise the issue will be closed in a week. Thank you for your contributions. |
|
Forgot this. I will rebase it tomorrow! |
|
@yeya24, before you rebase have you seen our final decision about naming? https://thanos.io/contributing/#components-naming |
|
@yeya24 Correct me if I'm wrong, but the decision was actually to keep command names as is in the code, no? |
|
@bwplotka @kakkoyun
And a small question: What about |
|
@yeya24 It should be |
Thanks. I will pin you after I finish. |
Signed-off-by: yeya24 <yb532204897@gmail.com> add changelog Signed-off-by: yeya24 <yb532204897@gmail.com>
| @@ -54,7 +54,7 @@ The meta.json is updated during upload time on sidecars. | |||
|
|
|||
| ``` | |||
| ┌────────────┬─────────┐ ┌────────────┬─────────┐ ┌─────────┐ | |||
| │ Prometheus │ Sidecar │ ... │ Prometheus │ Sidecar │ │ Rule │ | |||
| │ Prometheus │ Sidecar │ ... │ Prometheus │ Sidecar │ │ Ruler │ | |||
There was a problem hiding this comment.
Maybe we need to update the graph to add Receiver
|
I think it is ready. Based on https://thanos.io/contributing/#components-naming, most changes are just renaming in docs. Please correct me if I miss something. |
|
This issue/PR has been automatically marked as stale because it has not had recent activity. Please comment on status otherwise the issue will be closed in a week. Thank you for your contributions. |
Changes
Fixes #1871
Verification